Re: [whatwg/dom] Add Imperative Slot API (#860)

@annevk commented on this pull request.

I think this looks good now, modulo a couple minor nits.

> @@ -2195,6 +2195,10 @@ steps:</p>
  <li><p>If the <i>open flag</i> is set and <var>shadow</var>'s <a for=ShadowRoot>mode</a> is
  <em>not</em> "<code>open</code>", then return null.</p></li>
 
+ <li><p>If the <var>shadow</var>'s <a for=ShadowRoot>slot assignment</a> is set to "<code>manual</code>",
+ return the slot in <var>shadow</var>'s <a for=tree>descendants</a> whose <a>manuallyAssignedNodes</a>

```suggestion
 return the <a>slot</a> in <var>shadow</var>'s <a for=tree>descendants</a> whose <a>manuallyAssignedNodes</a>
```

> @@ -2195,6 +2195,10 @@ steps:</p>
  <li><p>If the <i>open flag</i> is set and <var>shadow</var>'s <a for=ShadowRoot>mode</a> is
  <em>not</em> "<code>open</code>", then return null.</p></li>
 
+ <li><p>If the <var>shadow</var>'s <a for=ShadowRoot>slot assignment</a> is set to "<code>manual</code>",

```suggestion
 <li><p>If <var>shadow</var>'s <a for=ShadowRoot>slot assignment</a> is set to "<code>manual</code>",
```

> @@ -2195,6 +2195,10 @@ steps:</p>
  <li><p>If the <i>open flag</i> is set and <var>shadow</var>'s <a for=ShadowRoot>mode</a> is
  <em>not</em> "<code>open</code>", then return null.</p></li>
 
+ <li><p>If the <var>shadow</var>'s <a for=ShadowRoot>slot assignment</a> is set to "<code>manual</code>",
+ return the slot in <var>shadow</var>'s <a for=tree>descendants</a> whose <a>manuallyAssignedNodes</a>

Since manually assigned nodes is a concept and not a variable, we probably don't want to use camelcase, but instead write it out.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/860#pullrequestreview-427992819