- From: Marcos Cáceres <notifications@github.com>
- Date: Tue, 09 Jun 2020 22:21:13 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/manifest/pull/833/review/427646646@github.com>
@marcoscaceres approved this pull request.
Couple of suggestions... otherwise looks great.
> @@ -2203,26 +2203,30 @@ <h3>
<a>purpose</a>.
</p>
<p class="note">
- For example, an icon with purpose "<a>badge</a>" could be used as a
- badge or pinned icon that is visually distinct, in color or form,
- from an application's launch icon. The user agent uses the value of
- the <a>purpose</a> member as a hint to determine where and how an
- <a>ImageResource</a> is displayed. Unless declared otherwise by the
- developer, a user agent can use an icon for <a>any purpose</a>.
+ For example, an icon with purpose "<a>monochrome</a>" could be used
+ as a badge or pinned icon with a solid fill, visually distinct from
+ an application's full color launch icon. The user agent uses the
+ value of the <a>purpose</a> member as a hint to determine where and
+ how an <a>ImageResource</a> is displayed. Unless declared otherwise
```suggestion
how an {{ImageResource}} is displayed. Unless declared otherwise
```
> @@ -2357,7 +2362,7 @@ <h2>
</p>
<p>
If the icon contains transparent pixels, the user agent MUST
- composite the icon onto a solid color (eg. white) of the user agent's
+ composite the icon onto a solid fill (eg. white) of the user agent's
```suggestion
composite the icon onto a solid fill (e.g., white) of the user agent's
```
> @@ -2439,6 +2444,87 @@ <h2 class="icon-title">
</div>
</section>
</section>
+ <section>
+ <h2>
+ Monochrome icons and solid fills
+ </h2>
+ <p>
+ Some platforms enforce that icons be displayed with a
+ <dfn>solid fill</dfn> such as a single color, where only the
+ transparency of the icon can be controlled by the application. As web
"controlled by the application" doesn't sound quite right here, as the app is not in any sort of control... may it should say:
```suggestion
transparency of the icon can be declared in a [=manifest=]. As web
```
> @@ -2439,6 +2444,87 @@ <h2 class="icon-title">
</div>
</section>
</section>
+ <section>
+ <h2>
+ Monochrome icons and solid fills
+ </h2>
+ <p>
+ Some platforms enforce that icons be displayed with a
+ <dfn>solid fill</dfn> such as a single color, where only the
+ transparency of the icon can be controlled by the application. As web
+ applications need to across multiple platforms, it is possible to
```suggestion
applications need to work across multiple platforms, it is possible to
```
> @@ -2439,6 +2444,87 @@ <h2 class="icon-title">
</div>
</section>
</section>
+ <section>
+ <h2>
+ Monochrome icons and solid fills
+ </h2>
+ <p>
+ Some platforms enforce that icons be displayed with a
+ <dfn>solid fill</dfn> such as a single color, where only the
+ transparency of the icon can be controlled by the application. As web
+ applications need to across multiple platforms, it is possible to
+ indicate that an icon can have an user-agent-specified color applied
+ by adding the <a>monochrome</a> purpose. This allows the platform
... hmmm... random thought... maybe the purpose should then called "platform-controlled"?
> + Monochrome icons and solid fills
+ </h2>
+ <p>
+ Some platforms enforce that icons be displayed with a
+ <dfn>solid fill</dfn> such as a single color, where only the
+ transparency of the icon can be controlled by the application. As web
+ applications need to across multiple platforms, it is possible to
+ indicate that an icon can have an user-agent-specified color applied
+ by adding the <a>monochrome</a> purpose. This allows the platform
+ to ensure that the icon looks well integrated with the platform, and
+ even apply different colors and padding in different places
+ throughout the platform.
+ </p>
+ <p>
+ When processing a <a>monochrome</a> icon, the user agent MUST NOT
+ use the red component, green component, or blue component of a pixel.
It's not clear what "use" means here... maybe "MUST NOT independently display" or something?
> + </h2>
+ <p>
+ Some platforms enforce that icons be displayed with a
+ <dfn>solid fill</dfn> such as a single color, where only the
+ transparency of the icon can be controlled by the application. As web
+ applications need to across multiple platforms, it is possible to
+ indicate that an icon can have an user-agent-specified color applied
+ by adding the <a>monochrome</a> purpose. This allows the platform
+ to ensure that the icon looks well integrated with the platform, and
+ even apply different colors and padding in different places
+ throughout the platform.
+ </p>
+ <p>
+ When processing a <a>monochrome</a> icon, the user agent MUST NOT
+ use the red component, green component, or blue component of a pixel.
+ The user agent SHOULD display each pixel with its original alpha
Question: the icons are passed to the OS, so I does this SHOULD apply to the user agent or the OS? Or are there situations where the browser is showing these.... there might be... just wondering?
> + indicate that an icon can have an user-agent-specified color applied
+ by adding the <a>monochrome</a> purpose. This allows the platform
+ to ensure that the icon looks well integrated with the platform, and
+ even apply different colors and padding in different places
+ throughout the platform.
+ </p>
+ <p>
+ When processing a <a>monochrome</a> icon, the user agent MUST NOT
+ use the red component, green component, or blue component of a pixel.
+ The user agent SHOULD display each pixel with its original alpha
+ value, but with a red, green, and blue value of the user agent's
+ choosing. It is RECOMMENDED that the user agent use the same color
+ value for all pixels.
+ </p>
+ <p class="note">
+ Designers of <a>monochrome</a> icons could set all pixels to black
Would this be considered best practice?
> + When processing a <a>monochrome</a> icon, the user agent MUST NOT
+ use the red component, green component, or blue component of a pixel.
+ The user agent SHOULD display each pixel with its original alpha
+ value, but with a red, green, and blue value of the user agent's
+ choosing. It is RECOMMENDED that the user agent use the same color
+ value for all pixels.
+ </p>
+ <p class="note">
+ Designers of <a>monochrome</a> icons could set all pixels to black
+ and only use transparency to create a silhouette of their icon.
+ </p>
+ <p>
+ The user agent MAY enlarge the icon by adding additional padding.
+ </p>
+ <p>
+ The user agent MAY add a background of any color behind transparent
Should we say something about contrast, or I guess it happens automatically because it's 'monochrome'?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/833#pullrequestreview-427646646
Received on Wednesday, 10 June 2020 05:21:26 UTC