- From: Marcos Cáceres <notifications@github.com>
- Date: Mon, 08 Jun 2020 17:24:08 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/manifest/pull/898/review/426706445@github.com>
@marcoscaceres requested changes on this pull request.
> + <li>[[CORE-AAM]] defines the following terms:
+ <ul>
+ <li>
+ <a data-cite="CORE-AAM#dfn-accessible-name"><dfn>accessible
+ name</dfn></a>
+ </li>
+ <li>
+ <a data-cite="CORE-AAM#dfn-accessible-description"><dfn>accessible
+ description</dfn></a>
+ </li>
+ </ul>
+ </li>
+ <li>[[MEDIAQUERIES-5]] defines the following terms:
+ <ul>
+ <li>
+ <a data-cite="MEDIAQUERIES-5#prefers-color-scheme"><dfn>user-preferred
+ color scheme</dfn></a>
+ </li>
+ </ul>
+ </li>
+ mediaqueries-5
We can get these exported from the appropriate spec...
```suggestion
```
> @@ -2174,6 +2189,14 @@ <h3>
<li>Return <var>color</var>.
</li>
</ol>
+ <section>
+ <h4>Accessible Colors</h3>
+ <p>
+ Implementors MAY choose to override the value defined by the
```suggestion
Implementors MAY override the value defined by the
```
> @@ -1779,6 +1779,13 @@ <h3>
(e.g., amongst a list of other applications, or as a label for an
icon).
</p>
+ <section>
+ <h4>Accessible Name</h3>
+ <p>
+ The [=accessible name=] of the web application is equal to the
+ value of the <code>name</code> member.
```suggestion
value of the {{WebAppManifest/name}} member.
```
> @@ -1779,6 +1779,13 @@ <h3>
(e.g., amongst a list of other applications, or as a label for an
icon).
</p>
+ <section>
Not sure we need an entirely new section for this... let's just move the `<p>` into the the description of the member. Same for the other ones.
> @@ -1799,6 +1806,14 @@ <h3>
The <dfn>description</dfn> member allows the developer to describe
the purpose of the web application.
</p>
+ <section>
+ <h4>Accessible Description</h3>
+ <p>
+ The [=accessible description=] of the web application is equal to
+ the value of the <code>description</code> member, if it is provided
```suggestion
the value of the {{WebAppManifest/description}} member, if it is provided
```
> @@ -2293,6 +2316,14 @@ <h3>
<li>Return <var>color</var>.
</li>
</ol>
+ <section>
+ <h4>Accessible Colors</h3>
+ <p>
+ Implementors MAY choose to override the value defined by the
```suggestion
Implementors MAY override the value defined by the
```
> @@ -2293,6 +2316,14 @@ <h3>
<li>Return <var>color</var>.
</li>
</ol>
+ <section>
+ <h4>Accessible Colors</h3>
+ <p>
+ Implementors MAY choose to override the value defined by the
+ <a>background_color</a> member to support a [=user-preferred color
```suggestion
{{WebAppManifest/background_color}} member to support a [=user-preferred color
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/898#pullrequestreview-426706445
Received on Tuesday, 9 June 2020 00:24:21 UTC