- From: Yash Handa <notifications@github.com>
- Date: Fri, 05 Jun 2020 12:20:26 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/869@github.com>
As discussed in #745, I made the required changes for clarification on the shadow element's local name.
It follows the formate specified in https://github.com/whatwg/dom/issues/745#issuecomment-639329890 by @annevk.
A side note:
There was an error during the `make` process, on both unedited and edited versions of dom.bs
```txt
Error running preprocessor, returned code: 1.
LINK ERROR: No 'dfn' refs found for 'case-sensitive' that are marked for export.
&lt;a data-link-type="dfn" data-lt="case-sensitive">case-sensitive&lt;/a>
✘ Did not generate, due to fatal errors
make: *** [Makefile:5: remote] Error 22
```
Due to which I couldn't verify my changes, so please let me know if something is off : )
<!--
This comment and the below content is programatically generated.
You may add a comma-separated list of anchors you'd like a
direct link to below (e.g. #idl-serializers, #idl-sequence):
Don't remove this comment or modify anything below this line.
If you don't want a preview generated for this pull request,
just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
***
<a href="https://whatpr.org/dom/869.html" title="Last updated on Jun 5, 2020, 7:19 PM UTC (4ae8221)">Preview</a> | <a href="https://whatpr.org/dom/869/f3f46b8...4ae8221.html" title="Last updated on Jun 5, 2020, 7:19 PM UTC (4ae8221)">Diff</a>
You can view, comment on, or merge this pull request online at:
https://github.com/whatwg/dom/pull/869
-- Commit Summary --
* clarification of valid shadow elemet local name
-- File Changes --
M dom.bs (49)
-- Patch Links --
https://github.com/whatwg/dom/pull/869.patch
https://github.com/whatwg/dom/pull/869.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/869
Received on Friday, 5 June 2020 19:20:38 UTC