Re: [w3c/manifest] BREAKING CHANGE: Replace "badge" with "monochrome" (#833)

@mgiuca approved this pull request.

Looks great, Tiger!

Just a few nits on the writing style. Ready to merge.

>            </dt>
           <dd>
-            A user agent can present this icon where space constraints and/or
-            color requirements differ from those of the application icon.
+            A user agent can present this icon where a
+            <a href="#monochrome-icons-and-solid-fills">monochrome icon with a
+            solid fill</a> is needed. The color information in the icon is
+            discarded and only the alpha data is used. The icon can then be
+            used user agent like a mask over any colored background.

I don't have a specific rephrasing, but the use of the word "mask" gave me pause, given your previous comment about how you don't want to use "mask" terminology here to avoid confusion with "maskable". It's probably fine to keep it as-is.

>            </dd>
           <dt>
-            <dfn data-lt="badge maskable">maskable</dfn>:
+            <dfn data-lt="maskable purpose">maskable</dfn>:

Good catch!

> @@ -2241,9 +2245,10 @@ <h3>
           If an icon contains multiple purposes, it could be used for any of
           those purposes. If none of the stated purposes are recognized, the
           icon is totally ignored. For example, if an icon has purpose
-          <code>"badge fizzbuzz"</code>, then it could be used as a badge, but
-          if an icon has just the purpose <code>"fizzbuzz"</code>, then it will
-          be ignored.
+          <code>"monochrome fizzbuzz"</code>, then it could be used as a
+          monochrome icon as <code>"monochrome"</code> is a valid purpose.

Nit: Add a comma after "icon".

("monochrome icon, as "monochrome" ...)

> @@ -2439,6 +2444,87 @@ <h2 class="icon-title">
           </div>
         </section>
       </section>
+      <section>
+        <h2>
+          Monochrome icons and solid fills
+        </h2>
+        <p>
+          Some platforms enforce that icons be displayed with a
+          <dfn>solid fill</dfn> such as a single color, where only the
+          transparency of the icon can be controlled by the application. As web
+          applications need to across multiple platforms, it is possible to
+          indicate  that an icon can have an user-agent-specified color applied

Nit: Two spaces after "indicate".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/833#pullrequestreview-424980548