- From: Domenic Denicola <notifications@github.com>
- Date: Thu, 04 Jun 2020 08:29:40 -0700
- To: whatwg/storage <storage@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/storage/pull/93/review/424560301@github.com>
@domenic approved this pull request. > @@ -185,13 +185,30 @@ anticipated that some APIs will be applicable to both <a>storage types</a> going <!-- If that does not happen by 2024 we probably ought to admit defeat and simplify this a bit. --> -<h3 id=storage-sheds>Storage sheds</h3> +<h3 id=storage-keys>Storage keys</h3> <p>A <dfn>storage key</dfn> is an <a for=/>origin</a>. [[HTML]] <p class=XXX>This is expected to change, see ```suggestion <p class=XXX>This is expected to change; see ``` > -<p class="XXX" id=lack-of-browsing-session>See -<a href="https://github.com/whatwg/html/issues/4782">whatwg/html issue #4782</a> and -<a href="https://github.com/whatwg/html/issues/5350">whatwg/html issue #5350</a> for defining -browsing session. It is roughly analogous to <a>top-level browsing context</a> except that it cannot -be replaced due to <code>Cross-Origin-Opener-Policy</code> or navigation. +<p class="note">This is considered legacy as the benefits, if any, do not outweigh the +implementation complexity. And therefore it will not be used for <a>session storage</a> beyond the +above. "beyond the above" -> "beyond its one existing usage in HTML"? > - <li><p>Set <var>shed</var>[<var>key</var>] to <var>shelf</var>. - </ol> + <li><p>If <var>shed</var>[<var>key</var>] does not <a for=map>exist</a>, then set + <var>shed</var>[<var>key</var>] to the result of running <a>create a storage shelf</a> with "the result of creating a storage shelf" perhaps? > + + +<h3 id=storage-pressure>Storage pressure</h3> + +<p>A user agent that comes under storage pressure should clear network state and +<a>local storage buckets</a> whose <a for="local storage bucket">mode</a> is +"<code>best-effort</code>", ideally prioritizing removal in a manner that least impacts the user. + +<p>If a user agent continues to be under storage pressure, then the user agent should inform the +user and offer a way to clear the remaining <a>local storage buckets</a>, i.e., those whose +<a for="local storage bucket">mode</a> is "<code>persistent</code>". + +<p><a>Session storage buckets</a> must be cleared as <a for=/>browsing sessions</a> are closed. + +<p class="note">If the user agent allows revival of <a for=/>browsing sessions</a>, then nothing can +be cleared until revival is no longer possible. I think HTML's > The lifetime of a browsing context can be unrelated to the lifetime of the actual user agent process itself, as the user agent can support resuming sessions after a restart. provides extra clarity, whereas this note is not as connected to the user experience of sessions surviving a restart. I'd suggest adding something like > This means that cessation of the user agent process might not allow clearing session storage, if restarting the user agent revives previously-active browsing sessions. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/storage/pull/93#pullrequestreview-424560301
Received on Thursday, 4 June 2020 15:29:55 UTC