Re: [w3c/manifest] chore: refactor and export scope terms (#882)

@mgiuca commented on this pull request.



>          </li>
-        <li>Otherwise, return <code>false</code>.
+        <li>Return a boolean indicating if |targetPath| starts with

I think you can link `[=infra/boolean=]` (https://infra.spec.whatwg.org/#boolean).

Nitty nit: In prose text, "Boolean" is always capitalized because it is named after a person. So we would only use a lowercase "b" if referring to a data type (i.e., if it is linked to infra).

>          </li>
       </ol>
       <p>
-        A <a>URL</a> <var>target</var> is said to be <dfn data-lt=
-        "within-scope-manifest">within scope of a manifest</dfn>
-        <var>manifest</var> if <var>target</var> is <a>within scope</a> of the
-        navigation scope of <var>manifest</var>.
+        A [=URL=] |target:URL| is said to be <dfn data-export="" data-dfn-for=
+        "processed manifest" data-lt="within scope">within the navigation scope
+        of a processed manifest</dfn> {{WebAppManifest}}

I think my previous comment on this may have been lost (?).

If you change the definition of "navigation scope" above to:

> The navigation scope of a [processed manifest](https://www.w3.org/TR/appmanifest/#dfn-processed-manifest) manifest is manifest [" scope "].

(i.e., s/manifest/processed manifest/ and link to the definition)

Then change this definition to "if _target_ is within scope of the navigation scope of _manifest_."

You should also change "processed manifest {{WebAppManifest}}" to just "processed manifest", linking that term to the appropriate definition.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/882#pullrequestreview-421546892