Re: [whatwg/streams] Add examples for stopping pipes (#1059)

@ricea approved this pull request.

lgtm

> @@ -868,6 +868,49 @@ option. If {{UnderlyingSource/type}} is set to undefined (including via omission
     |options|["{{StreamPipeOptions/preventClose}}"],
     |options|["{{StreamPipeOptions/preventAbort}}"],
     |options|["{{StreamPipeOptions/preventCancel}}"], |signal|).
+
+ <div class="example" id="example-pipe-abortsignal">
+  An ongoing [=pipe=] operation can be stopped using an {{AbortSignal}}, as follows:
+
+  <xmp highlight="js">
+   const controller = new AbortController();
+   readable.pipeTo(writable, { signal: controller.signal });
+
+   // ... some time later ...
+   controller.abort();
+  </xmp>
+
+  (The above omits error handling for the promise returned by {{ReadableStream/pipeTo()}}.

Having two sentences inside "()" looks a little odd to me. I think you could just omit the "()" here. If you like. I don't have really strong feelings about it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1059#pullrequestreview-455506776