- From: Adam Rice <notifications@github.com>
- Date: Fri, 10 Jul 2020 21:23:37 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Saturday, 11 July 2020 04:23:49 UTC
@ricea commented on this pull request.
> + 1. Set |backpressurePromise| to [=a new promise=].
+ 1. Otherwise, if |type| is `"close"`,
+ 1. Perform ! [$ReadableStreamDefaultControllerClose$](|controller|).
+ 1. Disentangle |port|.
+ 1. Otherwise, if |type| is `"error"`,
+ 1. Perform ! [$ReadableStreamDefaultControllerError$](|controller|, |value|)
+ 1. Disentangle |port|.
+ 1. Add a handler for |port|'s {{MessagePort/messageerror}} event with the following steps:
+ 1. Let |error| be a new "{{DataCloneError}}" {{DOMException}}.
+ 1. Perform ! [$CrossRealmTransformSendError$](|port|, |error|).
+ 1. Perform ! [$ReadableStreamDefaultControllerError$](|controller|, |error|).
+ 1. Disentangle |port|.
+ 1. Let |startAlgorithm| be an algorithm that returns undefined.
+ 1. Let |pullAlgorithm| be the following steps:
+ 1. Perform ! [$PackAndPostMessage$](|port|, `"pull"`, undefined).
+ 1. Return |backpressurePromise|.
I tested removing `backpressurePromise` in Blink and it works, so I've done the same thing here.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1053#discussion_r453153385
Received on Saturday, 11 July 2020 04:23:49 UTC