Re: [w3c/manifest] Processing the manifest is no longer a function of document URL (#834)

Yeah... it looks like all the WPTs are manual right now. Is that sufficient?

It kind of sucks because the manifest processor is in theory a very cleanly testable mathematical function (input string -> output data structure, no side effects). [Chromium's test suite](third_party/blink/renderer/modules/manifest/manifest_parser_unittest.cc), for example, includes literally hundreds of tiny test cases that test this processor's expected output, and that's what I've been playing with during this experiment.

But I don't see how to translate that to WPT, since we have no way of verifying the browser's internal representation of the manifest. We can do a handful of manual test cases, but I wouldn't want to translate Chromium's O(hundreds) of tests into manual tests.

TBH, I've given this particular issue way (waaaay) more time than I really can afford, and I need to move on to other things. I don't know if I have the bandwidth to add new tests here (I could _update_ existing tests, but it's a big investment to create them from scratch).

FYI here is the corresponding Chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/2280807
You can see the updates to the test suite in the third file.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/834#issuecomment-656526637