Re: [whatwg/streams] Fix typo in Close/Enqueue checks for readable byte streams (#1051)

> The API will throw a TypeError when these checks fail, so it's not possible to reach the abstract op with a problematic state.

In that case, can we change them to asserts?

> shouldn't we do the same thing for TransformStreamDefaultControllerEnqueue? That means:

It looks like this might have a normative effect on SetUpTransformStreamDefaultControllerFromTransformer, where 2.2 would no longer trigger. I'm not sure though if the branch is ever reached though...

> (Even more of a tangent: I just noticed that the anchor links for these transform stream abstract ops are weird. For example, TransformStreamDefaultControllerEnqueue is linked as #set-up-transform-stream-default-controller-enqueue. The set-up- bit looks like a copy-paste error? 😅)

This was presumably broken in the Web IDL rewrite; good catch! https://streams.spec.whatwg.org/commit-snapshots/cfcd303a38158e4ec3837d1028158c88d505c35d/#transform-stream-default-controller-enqueue has the more-correct abstract operation IDs. A fix, perhaps in this PR, would be lovely.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1051#issuecomment-654426342