- From: ExE Boss <notifications@github.com>
- Date: Thu, 02 Jul 2020 07:15:31 -0700
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <heycam/webidl/pull/901@github.com>
This fixes up <https://github.com/heycam/webidl/pull/871>, where I missed the fact that interface prototype objects of global objects and objects in the prototype chain of global objects have their `[[SetPrototypeOf]]` internal method changed in a way that makes them [immutable prototype exotic objects][immutable-prototype-exotic-objects].
---
Changing the `[[SetPrototypeOf]]` method of the result of [`OrdinaryObjectCreate`] goes against the intention of separating [`OrdinaryObjectCreate`] and [`MakeBasicObject`], so this fixes that.
[immutable-prototype-exotic-objects]: https://tc39.es/ecma262/#sec-immutable-prototype-exotic-objects
[`OrdinaryObjectCreate`]: https://tc39.es/ecma262/#sec-ordinaryobjectcreate
[`MakeBasicObject`]: https://tc39.es/ecma262/#sec-makebasicobject
You can view, comment on, or merge this pull request online at:
https://github.com/heycam/webidl/pull/901
-- Commit Summary --
* Editorial: Avoid changing internal methods of ordinary objects
-- File Changes --
M index.bs (18)
-- Patch Links --
https://github.com/heycam/webidl/pull/901.patch
https://github.com/heycam/webidl/pull/901.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/901
Received on Thursday, 2 July 2020 14:15:47 UTC