Re: [w3c/manifest] Processing the manifest is no longer a function of document URL (#834)

@mgiuca commented on this pull request.



> @@ -304,6 +304,10 @@ <h2>
             </li>
           </ul>
         </li>
+        <li>Otherwise, if |manifest|["{{WebAppManifest/start_url}}"] is not
+        present, or not <a>same origin</a> as the {{Document}}'s
+        {{Document/URL}}, consider the document not <a>installable</a>.

OK, I've updated the PR. I filed a bug #912 about the above issue (wherein Marcos and I agree, we shouldn't have "installability of the document") but I haven't tackled it here.

I've updated the text so the UA can now either consider the document not installable, OR can use the document URL to replace the off-origin start_url.

And I've updated the commit description. Actually, this is no longer a breaking change (!). You can carry on behaving exactly as before, if you like, which is replacing an invalid or off-origin start_url with the document URL, or you can error out (newly allowed behaviour). In one sense, this is now just a (useful) refactor, moving the replace-start-with-document logic up out of the manifest processor and into the "steps to determine installability of the document".

The next step in #912 will be rewriting those steps to be about postprocessing the manifest, not determining installability.

@marcoscaceres how is this?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/834#discussion_r448764694