- From: Marcos Cáceres <notifications@github.com>
- Date: Wed, 01 Jul 2020 19:51:33 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 2 July 2020 02:51:46 UTC
@marcoscaceres commented on this pull request.
> @@ -304,6 +304,10 @@ <h2>
</li>
</ul>
</li>
+ <li>Otherwise, if |manifest|["{{WebAppManifest/start_url}}"] is not
+ present, or not <a>same origin</a> as the {{Document}}'s
+ {{Document/URL}}, consider the document not <a>installable</a>.
> In Chromium we currently enforce that start_url and scope are same-origin with the document URL, which the spec requires. If that isn't met, we discard the values.
I think treating `start_url` as it if it was not present when it's not same origin or outside the scope makes sense, as does assigning it a sensible default (document URL) when in error. That can then remove the "installable" decision at that point (that shouldn't be part of the processing algorithm, IMO).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/834#discussion_r448719330
Received on Thursday, 2 July 2020 02:51:46 UTC