- From: Matt Giuca <notifications@github.com>
- Date: Wed, 01 Jul 2020 00:16:10 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 1 July 2020 07:16:22 UTC
OK, I updated the PR to explicitly invalidate `scope` if `start_url` is invalid. That addresses my post above. This is a bit unfortunate (though not a serious problem, since a non-installable app should not have to worry about scope). It's just annoying that `scope` is derived from `start_url` and not the other way around, since scope seems a much more fundamental property of an app than its start URL. If `start_url` were derived from `scope`, then an invalid scope would make the `start_url` invalid, but you could still have an app with a valid `scope` but not a valid `start_url`, which would mean it isn't installable, but you could have some manifest properties applied within the scope. I don't think this is a big deal; none of the existing applications should be affected by this. @marcoscaceres do you want to have another quick look at the changes I made, specifically in commit fa1563d. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/834#issuecomment-652238637
Received on Wednesday, 1 July 2020 07:16:22 UTC