- From: Jake Archibald <notifications@github.com>
- Date: Wed, 29 Jan 2020 07:28:00 -0800
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 29 January 2020 15:28:02 UTC
I think we should reject if the URL cannot be parsed, but otherwise we just resolve with undefined if the navigation ends in a network error. Iframes don't 'error' in these situations, so we shouldn't either. I propose: * Remove step 2 of https://w3c.github.io/ServiceWorker/#client-navigate which prevents `about:blank` as a value. * Change `about:blank` test so it's expected to resolve with undefined rather than reject. * Update tests so navigate only throws if the client's service worker isn't this service worker, if the url is invalid, or document has been discarded. @wanderview @asutherland @jungkees @matto @youennf any objections? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/issues/1500#issuecomment-579807947
Received on Wednesday, 29 January 2020 15:28:02 UTC