Re: [w3c/manifest] Processing the manifest is no longer a function of document URL (#834)

mgiuca commented on this pull request.



> @@ -322,6 +322,11 @@ <h2>
             </li>
           </ol>
         </li>
+        <li>Otherwise, if <var>manifest</var>["<a>start_url</a>"] is not
+        present, or not <a>within scope</a> of the {{Document}}'s
+          <a data-cite="DOM#dom-document-url">URL</a>, consider the document
+          not <a>installable</a>.
+        </li>

Oops. It's been awhile since I wrote this so I'm not sure what my intention was, but I suspect this was simply a mistake. It should have said "not same origin as", not "not within scope of".

That matches the existing check (which I'm removing), that would check if start_url was same origin as the document URL, and if not, ignore the supplied start_url and default to the document URL. Only now, we just consider it non-installable.

Does that sound right?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/834#discussion_r368378101