Re: [whatwg/dom] Avoid enqueuing tree mutation record when there is no mutation (#822)

annevk commented on this pull request.

Thanks, couple minor nits.

> @@ -2604,7 +2604,8 @@ within a <var>parent</var>, run these steps:
  <li><p>If <var>node</var> is non-null, then <a for=/>insert</a> <var>node</var> into
  <var>parent</var> before null with the <i>suppress observers flag</i> set.
 
- <li><p><a>Queue a tree mutation record</a> for <var>parent</var> with <var>addedNodes</var>,
+ <li><p>If either <var>addedNodes</var> or <var>removedNodes</var> <a for=list>is not empty</a>,

```suggestion
 <li><p>If either <var>addedNodes</var> or <var>removedNodes</var> <a for=set>is not empty</a>,
```

> @@ -3591,6 +3592,9 @@ run these steps:
 <var>target</var> with null, null, null, <var>addedNodes</var>, <var>removedNodes</var>,
 <var>previousSibling</var>, and <var>nextSibling</var>.
 
+<p class="note no-backref">Either <var>addedNodes</var> or <var>removedNodes</var>
+<a for=list>is not empty</a>.

This seems nice to call out, but then we should turn the thing above this into an algorithm with two steps and the first step is this, as an assert.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/822#pullrequestreview-344680624