We (mostly @hober and me) looked at this in our TAG breakout, we have some naming concerns and other similar concerns... but overall it seems fine. We are not a fan of APIs with `openOrCreate` - it could simply be called open or have a "`create: true`" as part of options, but we think auto creation is fine. All storage buckets have a `name` and also a `title` (metadata) you can set. You can go into settings and see a descriptive name. You run into issues of a11y, i18n and generally user agents have been reluctant to expose author-provided strings in security UI like that. Now a fan of the name of `persist`. It is unclear what it does and it is unclear if it modifies the object. Our naming advice would suggest a simpler name - like "`save`". Depends on what `persist` does. Regarding durability concept - durability `relax`/`strict` - is the UA free to delete things things? But even in `strict` if the UA is under storage pressure it's gonna get rid of your stuff. So - don't like APIs that imply to the author that this is durable. Maybe something like "`ephemeral`" and "`importan`t" would make more sense, as you indicate if you care about the content or not. `setExpires` -- doesn't it make sense to call it `setExpirationTime`? `setExpires` sounds like a boolean. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3ctag/design-reviews/issues/562#issuecomment-740079416
Received on Monday, 7 December 2020 17:56:27 UTC