Re: [whatwg/url] IPv4 host parser + site definition seems potentially dangerous. (#560)

I just realized that my suggestion would not actually catch `1.127` so indeed we need to do "dos" and adjust how IPv4 addresses are parsed in general. So perhaps the minimum change would that whenever there are not exactly four parts (after trailing dot elision which is probably fine still) we need to return _input_. And whenever we return _input_ we perform validation on _input_'s last label. (And perhaps performing validation on _input_'s last label should happen in the host parser, after attempting to extract an IPv4 address. It doesn't really matter but it seems a little cleaner to do it there.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/issues/560#issuecomment-736469814

Received on Tuesday, 1 December 2020 11:33:31 UTC