Re: [whatwg/dom] add signal to addEventListener (#919)

@annevk commented on this pull request.

Let me know if you want help with the final nits. Since I've done a couple rounds I would appreciate if @domenic could do a final spot check as well and then we can merge.

>   <li><p>If <var>options</var> is a dictionary, then set <var>passive</var> to <var>options</var>'s
- <code>{{AddEventListenerOptions/passive}}</code> and <var>once</var> to <var>options</var>'s
+ <code>{{AddEventListenerOptions/passive}}</code>, <var>once</var> to <var>options</var>'s

Please restore "and" here. Comma isn't needed then.

>   <code>{{AddEventListenerOptions/once}}</code>.
 
- <li><p>Return <var>capture</var>, <var>passive</var>, and <var>once</var>.
+ <li><p>If |options| is a dictionary and |options|["{{AddEventListenerOptions/signal}}"] [=map/exists=],
+ then set |signal| to |options|["{{AddEventListenerOptions/signal}}"].
+
+

One newline can go.

>   <code>{{AddEventListenerOptions/once}}</code>.
 
- <li><p>Return <var>capture</var>, <var>passive</var>, and <var>once</var>.
+ <li><p>If |options| is a dictionary and |options|["{{AddEventListenerOptions/signal}}"] [=map/exists=],
+ then set |signal| to |options|["{{AddEventListenerOptions/signal}}"].
+
+
+ <li><p>Return <var>capture</var>, <var>passive</var>, <var>once</var> and <var>signal</var>.

Oxford comma before and.

> @@ -1113,6 +1131,12 @@ participate in a tree structure.</p>
  <a for="event listener">callback</a>, and <a for="event listener">capture</a> is
  <var>listener</var>'s <a for="event listener">capture</a>, then <a for=list>append</a>
  <var>listener</var> to <var>eventTarget</var>'s <a>event listener list</a>.
+
+  <li><p>If <a for="event listener">signal</a> is not null then <a for=AbortSignal lt=add>add the following</a>

Newline before `<p>` (plus indent by a space) as this `<li>` contains multiple children.

Also comma before "then".

>   <li><p>If <var>options</var> is a dictionary, then set <var>passive</var> to <var>options</var>'s
- <code>{{AddEventListenerOptions/passive}}</code> and <var>once</var> to <var>options</var>'s
+ <code>{{AddEventListenerOptions/passive}}</code>, <var>once</var> to <var>options</var>'s

You might want to clean this up while here to use the same accessing syntax as below. So instead of `options's x` use `options[x]`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/919#pullrequestreview-541758595