Re: [whatwg/fetch] Allow a request body to be a byte sequence/string (#1083)

@domenic approved this pull request.

Very nice; nicer than what I was thinking of doing.

Do you think it's worth adding a note for callers that supply strings that they might want to set a Content-Type with a UTF-8 charset, since you're going to UTF-8 encode for them? Or maybe we shouldn't have the string input version, hmmm...

>  
-<p class="note no-backref">This can be updated during redirects to null as described in
-<a>HTTP fetch</a>.
+<p class="note no-backref">A <a for=/>byte sequence</a> and a <a for=/>scalar value string</a> will

```suggestion
<p class="note no-backref">A <a for=/>byte sequence</a> or a <a for=/>scalar value string</a> will
```

> @@ -5759,7 +5769,7 @@ typedef (ReadableStream or XMLHttpRequestBodyInit) BodyInit;</pre>
 
    <dt>{{ReadableStream}}
    <dd>
-    <p>If the <var>keepalive flag</var> is set, then <a>throw</a> a {{TypeError}}.
+    <p>If <a><var>keepalive</var></a> is true, then <a>throw</a> a {{TypeError}}.

```suggestion
    <p>If <var>keepalive</var> is true, then <a>throw</a> a {{TypeError}}.
```

Only call sites link; inside the algorithm we just treat them as variables.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1083#pullrequestreview-474654911