Re: [whatwg/streams] Editorial: add cross-links to internal slots (#1050)

@ricea approved this pull request.

Really elegant. lgtm.

Sorry for the delay in reviewing this. Feel free to merge once you've attended to the minor issues I raised.

>      exception.
- 1. Assert: [=this=].\[[view]].\[[ByteLength]] > 0.
- 1. Assert: [=this=].\[[view]].\[[ViewedArrayBuffer]].\[[ByeLength]] > 0.
- 1. Perform ? [$ReadableByteStreamControllerRespond$]([=this=].\[[controller]], |bytesWritten|).
+ 1. If [$IsDetachedBuffer$]([=this=].[=ReadableStreamBYOBRequest/[[view]]=].\[[ArrayBuffer]]) is
+    true, throw a {{TypeError}} exception.
+ 1. Assert: [=this=].[=ReadableStreamBYOBRequest/[[view]]=].\[[ByteLength]] > 0.
+ 1. Assert: [=this=].[=ReadableStreamBYOBRequest/[[view]]=].\[[ViewedArrayBuffer]].\[[ByeLength]]

```suggestion
 1. Assert: [=this=].[=ReadableStreamBYOBRequest/[[view]]=].\[[ViewedArrayBuffer]].\[[ByteLength]]
```
Could you fix this pre-existing typo while you are here?

> @@ -2079,24 +2112,26 @@ are even meant to be generally useful by other specifications.
     before performing any reads or writes, since they might lead to immediate shutdown.
   * <strong>Error and close states must be propagated:</strong> the following conditions must be
     applied in order.
-   1. <strong>Errors must be propagated forward:</strong> if |source|.\[[state]] is or becomes
-      "`errored`", then
+   1. <strong>Errors must be propagated forward:</strong>  if |source|.[=ReadableStream/[[state]]=]

```suggestion
   1. <strong>Errors must be propagated forward:</strong> if |source|.[=ReadableStream/[[state]]=]
```
Is this extra space needed?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1050#pullrequestreview-467080677