Re: [whatwg/streams] Editorial: add cross-links to internal slots (#1050)

@MattiasBuelens commented on this pull request.

I'm quite happy with how the `ReadableStreamGenericReader` mixin turned out! 😄

I did `ReadableStreamDefaultController`, `ReadableByteStreamController` and `ReadableStreamBYOBRequest` as well. This completes the work for readable streams.

Next up: writable streams!

>  
- <p class="note">The case where |stream|.\[[state]] is "`closed`", but |stream|.\[[closeRequested]]
+ <p class="note">The case where |stream|.[=ReadableStream/[[state]]=] is "`closed`", but |stream|.[=ReadableStream/[[controller]]=].\[[closeRequested]]

Drive-by fix: _stream_.\[[closeRequested]] should have been _stream_.\[[controller]].\[[closeRequested]]. (Fortunately, this note is non-normative! 😅)

>  
- <p class="note">The case where |stream|.\[[state]] is "`closed`", but |stream|.\[[closeRequested]]
+ <p class="note">The case where |stream|.[=ReadableStream/[[state]]=] is "`closed`", but |stream|.[=ReadableStream/[[controller]]=].\[[closeRequested]]

This is the only place where we refer to `[[closeRequested]]` without a specific type of controller. I think it's a bit overkill to introduce an interface mixin *just* for this non-normative note, so I'm tempted to only link to the internal slot on the default controller, i.e.:
```suggestion
 <p class="note">The case where |stream|.[=ReadableStream/[[state]]=] is "`closed`", but |stream|.[=ReadableStream/[[controller]]=].[=ReadableStreamDefaultController/[[closeRequested]]=]
```

Thoughts?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1050#pullrequestreview-465469022