Re: [whatwg/streams] Editorial: add cross-links to internal slots (#1050)

@MattiasBuelens commented on this pull request.

Well, I gave the interface mixin thingy a go, just to see what it'd look like. 😁

It's probably too big of a change, so I understand if we want to revert this for now.

> @@ -1131,14 +1178,14 @@ to filling the [=readable stream=]'s [=internal queue=] or changing its state. I
  The <dfn id="default-reader-closed" attribute for="ReadableStreamDefaultReader">closed</dfn>

I would have liked to remove the `closed` getter and `cancel(reason)` methods on `ReadableStreamDefaultReader` and `ReadableStreamBYOBReader`, in favor for using the definitions from `ReadableStreamGenericReader`. But apparently that would break the links to MDN, so the CI doesn't let me do that here. 🤷

I could make the steps perform the steps for `ReadableStreamGenericReader.closed` and `.cancel(reason)`, but I'm not sure how to formalize that.

> @@ -1007,6 +1007,62 @@ default-reader-asynciterator-prototype-internal-slots">Asynchronous iteration</h
  1. Return [=a promise resolved with=] undefined.
 </div>
 
+<h3 id="generic-reader-mixin">The {{ReadableStreamGenericReader}} interface mixin</h3>
+
+The {{ReadableStreamGenericReader}} interface mixin defines common internal slots, getters and
+methods that are shared between {{ReadableStreamDefaultReader}} and {{ReadableStreamBYOBReader}}
+objects.

Shamelessly stolen from [`TextDecoderCommon`](https://encoding.spec.whatwg.org/#interface-mixin-textdecodercommon). 😁 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1050#pullrequestreview-463602613