- From: Domenic Denicola <notifications@github.com>
- Date: Thu, 06 Aug 2020 08:07:27 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 6 August 2020 15:07:40 UTC
Here are some options that I'd be happy with: 1. Don't link for this special case. 2. Branch the spec in a way that reads kinda strange: "If reader is a ReadableStreamDefaultReader, resolve reader.[[closedPromise]] with undefined. If reader is a ReadableStreamBYOBReader, resolve reader.[[closedPromise]] with undefined." With each sentence having a difference link. 3. Add an "Interfacing with readers" section. Personally, I don't think we should change the IDL for this kind of internal factoring concern... although I can kind of see the appeal of formally expressing that this sub-part of the reader classes is shared, with its own identity. That is, this does feel a bit more like a shared sub-part, than like polymorphism. Anyway, (3) is a bit weird to me. Do we move the [[stream]] slot there too? Is this all for a single [[closedPromise]] manipulation? If such polymorphic access to [[closedPromise]] happens multiple times, then I'd feel better about (3). And if polymorphic access to [[stream]] happened, then I'd definitely say we should do (3). But if this is rare, then (1) or (2) seem more reasonable. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1050#issuecomment-669986341
Received on Thursday, 6 August 2020 15:07:40 UTC