Re: [whatwg/dom] Add Imperative Slot API (#860)

@annevk commented on this pull request.



> @@ -2195,6 +2195,11 @@ steps:</p>
  <li><p>If the <i>open flag</i> is set and <var>shadow</var>'s <a for=ShadowRoot>mode</a> is
  <em>not</em> "<code>open</code>", then return null.</p></li>
 
+ <li><p>If the shadow's <a for=ShadowRoot>slot assignment</a> is set to "<code>manual</code>",
+ return the associated <a>slot</a> in shadow where the <var>slottable</var> is
+ <a href="https://html.spec.whatwg.org/multipage/scripting.html#dom-slot-assign"><code>assigned</code></a>,

This is too much action-at-a-distance. A `slot` probably needs to keep track of what was manually assigned to it in some "associated" thingie.

> @@ -5731,6 +5738,9 @@ It is initially set to false.</p>
 <!-- If we ever change this, e.g., add a ShadowRoot object constructor, that would have serious
      consequences for innerHTML. -->
 
+<p><a for=/>Shadow roots</a> have an associated <dfn for=ShadowRoot>slot assignment</dfn>
+("<code>manual</code>" or "<code>auto</code>"), whose default value is "<code>auto</code>"</p>

Misses a dot.

> @@ -5713,9 +5718,11 @@ interface ShadowRoot : DocumentFragment {
   readonly attribute ShadowRootMode mode;
   readonly attribute Element host;
   attribute EventHandler onslotchange;
+  readonly attribute SlotAssignmentMode slotAssignment;

I think this should be listed under `mode`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/860#pullrequestreview-400127960