- From: Adam Rice <notifications@github.com>
- Date: Wed, 22 Apr 2020 16:06:28 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 22 April 2020 23:06:41 UTC
I spot-checked the markup and it looks okay. I'm going to trust in Bikeshed that it would point out any major problems if there were any. Async iteration changes look okay. From the point of view of the Blink implementation, it's okay to remove the old ids for non-exported abstract operations, as long as there is some id we can link to. It will temporarily break the links in our source code, but since we have to update it anyway it's not a huge burden. I think renaming slot names should be done in a separate change, simply because this change is already so huge it's hard to properly review it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1035#issuecomment-618084442
Received on Wednesday, 22 April 2020 23:06:41 UTC