- From: Adam Rice <notifications@github.com>
- Date: Wed, 22 Apr 2020 15:53:21 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/streams/pull/1035/review/398645432@github.com>
@ricea commented on this pull request. > -{{ReadableByteStreamController}}. Those classes define most of the stateful internal slots and abstract -operations for how a stream's <a>internal queue</a> is managed and how it interfaces with its <a>underlying source</a> -or <a>underlying byte source</a>. - -Each controller class defines two internal methods, which are called by the {{ReadableStream}} algorithms: - -<dl> - <dt><dfn abstract-op lt="[[CancelSteps]]">\[[CancelSteps]](<var>reason</var>)</dfn></dt> - <dd>The controller's steps that run in reaction to the stream being <a lt="cancel a readable stream">canceled</a>, - used to clean up the state stored in the controller and inform the <a>underlying source</a>.</dd> - - <dt><dfn abstract-op lt="[[PullSteps]]">\[[PullSteps]]()</dfn></dt> - <dd>The controller's steps that run when a <a>default reader</a> is read from, used to pull from the controller any - queued <a>chunks</a>, or pull from the <a>underlying source</a> to get more chunks.</dd> + <p>By default, calling the async iterator's `return()` method will also [=cancel a readable + stream|cancel=] the stream. To prevent this, use the stream's `values()`method, passing true for ```suggestion stream|cancel=] the stream. To prevent this, use the stream's `values()` method, passing true for ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1035#pullrequestreview-398645432
Received on Wednesday, 22 April 2020 22:53:34 UTC