Re: [whatwg/streams] Rewrite to use Web IDL, and generally modernize (#1035)

@ricea commented on this pull request.



> @@ -0,0 +1,203 @@
+'use strict';
+const utils = require('../../generated/utils.js');
+const { rethrowAssertionErrorRejection } = require('./miscellaneous.js');
+
+// https://heycam.github.io/webidl/#new
+// https://github.com/jsdom/webidl2js/issues/193
+exports.webidlNew = (globalObject, typeName, implModule) => {
+  if (globalObject[utils.ctorRegistrySymbol] === undefined) {
+    throw new Error('Internal error: invalid global object');
+  }
+
+  const ctor = globalObject[utils.ctorRegistrySymbol][typeName];
+  if (ctor === undefined) {

Maybe this should be an assert()?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1035#pullrequestreview-397763773