Re: [whatwg/streams] Rewrite to use Web IDL, and generally modernize (#1035)

@ricea commented on this pull request.



> +    }
+    if (wsAOs.IsWritableStreamLocked(transform.writable) === true) {
+      throw new TypeError('ReadableStream.prototype.pipeThrough cannot be used on a locked WritableStream');
+    }
+
+    const promise = aos.ReadableStreamPipeTo(
+      this, transform.writable, options.preventClose, options.preventAbort, options.preventCancel, options.signal
+    );
+
+    setPromiseIsHandledToTrue(promise);
+
+    return transform.readable;
+  }
+
+  pipeTo(destination, options) {
+    // Conversion here is needed until https://github.com/jsdom/webidl2js/issues/81 is fixed.

I find the word "conversion" confusing here. Would "type checking" be acceptable instead?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1035#pullrequestreview-397734738