Re: [whatwg/streams] Rewrite to use Web IDL, and generally modernize (#1035)

@domenic commented on this pull request.



>  </div>
 
-<emu-alg>
-  1. If ! IsReadableStreamBYOBReader(*this*) is *false*, return <a>a promise rejected with</a> a *TypeError* exception.
-  1. If *this*.[[ownerReadableStream]] is *undefined*, return <a>a promise rejected with</a> a *TypeError* exception.
-  1. If Type(_view_) is not Object, return <a>a promise rejected with</a> a *TypeError* exception.
-  1. If _view_ does not have a [[ViewedArrayBuffer]] internal slot, return <a>a promise rejected with</a> a *TypeError*
-     exception.
-  1. If ! IsDetachedBuffer(_view_.[[ViewedArrayBuffer]]) is *true*, return <a>a promise rejected with</a> a *TypeError*

Hmm, I thought it threw an error when converting, but I see that's not accurate, at least in the spec. Uh-oh. I'll want to check implementations, but if the Web IDL spec is correct, then yeah, I made some wrong assumptions. Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1035#discussion_r410715963

Received on Saturday, 18 April 2020 16:01:42 UTC