- From: L. David Baron <notifications@github.com>
- Date: Fri, 17 Apr 2020 16:13:21 -0700
- To: w3ctag/design-reviews <design-reviews@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 17 April 2020 23:13:34 UTC
So a few responses to those issues: * `diameter` still doesn't say what sort of units it has. Is it CSS pixels? Device pixels? Something else? And should it really just be a number, or a string that accepts all sorts of CSS lengths with different units? * for `presentationArea`, if it's an element **or `null`**, then it should probably be written with a question mark as: ```webidl readonly attribute Element? presentationArea; ``` Likewise, the argument to `requestPresenter` should probably be `optional Element? presentationArea = null`. Also, if "bounding box" means [border box](https://drafts.csswg.org/css-box/#border-box), perhaps it should use that term? If not, what does it mean? * I'm not particularly convinced about the extensibility, but I'm also not sufficiently unconvinced that I'd strongly argue that it shouldn't be there. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3ctag/design-reviews/issues/473#issuecomment-615502113
Received on Friday, 17 April 2020 23:13:34 UTC