- From: Shivani Sharma <notifications@github.com>
- Date: Mon, 06 Apr 2020 07:09:59 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 6 April 2020 14:10:14 UTC
> > Both issues mentioned [#943 (comment)](https://github.com/whatwg/fetch/pull/943#discussion_r399082089) seem pretty problematic to me: > > > One example is a user-initiated top-level navigation. For those we should use the site of the request URL, but this would not do that. > > > I suspect the client is also wrong if tab A navigates tab B. We wouldn't want to use the key from tab A. > > > > > > Unfortunately I don't really have a complete handle on the appropriate fix. > > For navigation requests we probably need to use the reserved client. However, that doesn't always have the top-level origin at the moment. > > Ah, I didn't realize that navigation requests settings object does not have the destination origin. Uploaded a patch that uses target browsing context's settings object if the request is a navigation request. I am assuming that the target browsing context has been set up with the settings object at this point in fetch. Can you take a look if this solves the issue. Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/943#issuecomment-609818450
Received on Monday, 6 April 2020 14:10:14 UTC