Re: [w3c/manifest] Remove beforeinstallprompt event + window.oninstalled (#836)

@mgiuca approved this pull request.

A few comments requested but otherwise this looks good. 😭

The title of the commit should change. It's `onappinstalled` not `oninstalled`, but just for consistency use the same form for both events. "Remove beforeinstallprompt and appinstalled events." Mention in the commit text that this also removes install prompting and the installation algorithm itself. (Which still seems a bit aggressive to me, but I suppose it isn't too necessary to specify it when we don't have specified way to prompt for install.)

@dominickng @dmurph FYI

>          </li>
-        <li>Otherwise, the {{Document}} MAY be considered <a>installable</a>
-        (at the user agent's discretion; see [[[#installability-signals]]]).
+        <li>Otherwise, the {{Document}} is considered <a>installable</a> (at

I don't know why "MAY" changed to "is". It's still a may, because you still allow user agent discretion.

>        <section>
         <h3 id="installation-sec">
           Privacy and security considerations
         </h3>
         <p>
-          During the <a>presentation of the install prompt</a>, it is
-          RECOMMENDED that the user agent allow the end-user to inspect the
-          icon, name, <a>start URL</a>, origin, etc. pertaining to a web
-          application. This is to give an end-user an opportunity to make a
-          conscious decision to approve, and possibly modify, the information
-          pertaining to the web application before installing it. This also
-          gives the end-user an opportunity to discern if the web application
-          is spoofing another web application, by, for example, using an
-          unexpected icon or name.
+          It is RECOMMENDED that UI that affords the end user the ability to
+          <a>install</a> a web application also allow inspecting the icon,

s/allow/allows (tbh this is goes past my concrete understanding of English grammar, but "allows" as opposed to "allow" feels correct in this sentence).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/836#pullrequestreview-385288548