Re: [w3c/manifest] Rewrite installation process and install prompting logic (#790)

marcoscaceres approved this pull request.

Pre-approving... I still think the the |result| + in parallel could be a bit clearer, but overall this is a great improvement. Nice work @mgiuca.  

> +        <li>If <a>obtaining the manifest</a> results in an error, the user
+        agent MAY either:
+          <ol>
+            <li>Fall back to using the <a>top-level browsing context</a>
+            {{Document}}'s metadata to to populate <var>manifest</var> in a
+            user-agent-specific way (e.g., setting
+            |manifest|.{{WebAppManifest/name}} to the document <a data-cite=
+            "HTML#the-title-element">`title`</a>) and considering the document
+            <a>installable</a>.
+            </li>
+            <li>Or, consider the document not <a>installable</a>.
+            </li>
+          </ol>
+        </li>
+        <li>Otherwise, the {{Document}} MAY be considered <a>installable</a>
+        (at the user agent's discretion; see <a href="#installability-signals">

This should auto-expand to the right section. 
```suggestion
        (at the user agent's discretion; see [[[#installability-signals]]].
```

> +        agent MAY either:
+          <ol>
+            <li>Fall back to using the <a>top-level browsing context</a>
+            {{Document}}'s metadata to to populate <var>manifest</var> in a
+            user-agent-specific way (e.g., setting
+            |manifest|.{{WebAppManifest/name}} to the document <a data-cite=
+            "HTML#the-title-element">`title`</a>) and considering the document
+            <a>installable</a>.
+            </li>
+            <li>Or, consider the document not <a>installable</a>.
+            </li>
+          </ol>
+        </li>
+        <li>Otherwise, the {{Document}} MAY be considered <a>installable</a>
+        (at the user agent's discretion; see <a href="#installability-signals">
+          Installability signals</a>).

```suggestion
```

> -          <dfn>automated install prompt</dfn>: that is, a <abbr>UI</abbr> that
-          the user agent presents to the user when, for instance, there are
-          sufficient <a>installability signals</a> to warrant
-          <a>installation</a> of the web application.
-          </li>
-          <li>The <a>installation process</a> can occur through a
-          <dfn>site-triggered install prompt</dfn>: the site can
-          programmatically request that the user agent present an install
-          prompt to the user. The user agent MAY restrict the availability of
-          this feature to cases where, for instance, there are sufficient
+          trigger the installation process through the user agent's
+            <abbr title="User Interface">UI</abbr>, directly invoking the steps
+            to <a>present an install prompt</a>.
+          </li>
+          <li>The installation process can occur through an <dfn>automated
+          install prompt</dfn>: that is, a <abbr>UI</abbr> that the user agent

ReSpec will add abbr automagically. 

```suggestion
          install prompt</dfn>: that is, a UI that the user agent
```

>          </p>
+        <ol>
+          <li>Show some user-agent-specific UI, asking the user whether to
+          proceed with installing the app. See <a href=
+          "#installation-sec">privacy and security considerations</a> for
+          recommendations relating to this UI. The <var>result</var> of this
+          choice is either <a data-link-for=
+          "AppBannerPromptOutcome">accepted</a> or <a data-link-for=
+          "AppBannerPromptOutcome">dismissed</a>.
+          </li>
+          <li>If <var>result</var> is <a data-link-for=
+          "AppBannerPromptOutcome">accepted</a>, then in parallel, run the <a>
+            steps to install the web application</a>.
+          </li>
+          <li>Return <var>result</var>.

Ok, alternative:

```
<li>Return |result| and in parallel: .... 
```
 
That way it's clear that in parallel goes off to do other things independently of |result|. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/790#pullrequestreview-292199566