Re: [w3c/IndexedDB] Remove WebIDL escaping of includes() method (#299)

aliams requested changes on this pull request.

LGTM. I have some feedback on the changes made to the code examples.

>  
 request.onupgradeneeded = function() {
   // The database did not previously exist, so create object stores and indexes.
-  var db = request.result;
-  var store = db.createObjectStore("books", {keyPath: "isbn"});
-  var titleIndex = store.createIndex("by_title", "title", {unique: true});
-  var authorIndex = store.createIndex("by_author", "author");
+  const db = request.result;

Should const be here? I believe the goal was to set the variable in the outer scope context.

>  
 request.onupgradeneeded = function(event) {
-  var db = request.result;
+  const db = request.result;

Same as before: should const be here? I believe the goal was to set the variable in the outer scope context.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/IndexedDB/pull/299#pullrequestreview-292067904