- From: Matt Giuca <notifications@github.com>
- Date: Thu, 19 Sep 2019 23:18:36 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 20 September 2019 06:18:58 UTC
mgiuca commented on this pull request. > @@ -359,11 +358,13 @@ <h3> relevant settings object</a>, or <code>null</code> if unavailable. </li> - <li>Invoke <a>Start Register</a> with <var>scope</var> and - <var>src</var> members of the <var>registration</var>, a new - <var>promise</var>, <var>client</var>, <a>manifest URL</a>, - plus the <var>type</var> and <var>use_cache</var> members of - the <var>registration</var>, + <li>Invoke <a href= I already have a PR out for this: #792. It's a lot more extensive than what's here (you can't just invoke Register with those arguments). Can you just remove this change and I'll land that PR later? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/801#pullrequestreview-290971422
Received on Friday, 20 September 2019 06:18:58 UTC