Re: [w3c/manifest] Make BeforeInstallPrompt optional (#797)

mgiuca approved this pull request.



>        <h2>
         Installation Events
       </h2>
+      <p>
+        Installation events and supporting the {{BeforeInstallPrompt}} is

I'm not sure why "installation events" (which includes appinstalled) is optional. I don't think there's anything particularly controversial about appinstalled is there? We should get that supported everywhere.

I'm happy to mark BIP as optional, since it's effectively optional already, as it's up to the user agent to decide when and if to fire it (so any user agent that doesn't implement it could claim conformance already). Marking it as optional just makes that clear (and also makes it legal for window.BeforeInstallPromptEvent to not exist).

> @@ -562,10 +562,14 @@ <h3>
         </p>
       </section>
     </section>
-    <section>
+    <section class="atrisk">

Has there been any more discussion about the "at risk" status of this feature? I don't think we can just deprecate it at this point; too many sites rely on it (though as I say below, I think it's fine for it to be perpetually optional).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/797#pullrequestreview-290333173