- From: Piotrek Koszuliński <notifications@github.com>
- Date: Sun, 15 Sep 2019 10:13:28 -0700
- To: w3c/editing <editing@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Sunday, 15 September 2019 17:13:51 UTC
> Are you saying you would just add/delete entries to the undo stack to always have the right amount of undo/redo items in the browser's stack? Do you mean the depth of the stack? Yep, we could do that. Regarding deleting redo steps if a user undid some changes and then e.g. typed a letter which meant that a new item appeared so `addItem()` was called – that's described in `addItem()`'s algorithm that it will clear all items with indexes greater than the current state: > 6. Clear redo items on hisotry represented by undoManager. So, I think that it shouldn't be a problem to keep both stacks in sync. Regarding labels – I don't think we'd ever use any other label than "Editing" (or no label, so just "Undo"/"Redo"). The ROI of naming all the actions that the user can do is close to zero for me. AFAIU, this label would only visible when using the context menu or the top menu – I'd say that those are the least common ways to undo things in our case. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/editing/issues/209#issuecomment-531582926
Received on Sunday, 15 September 2019 17:13:51 UTC