Re: [w3ctag/design-reviews] Display Locking (#306)

> One minor thing worth noting: You state in the first para of the motivation section that "web developers need ways to reduce loading and rendering time of web apps that have a lot of DOM." I wish you would explicitly call out the user-facing need that leads to this. Something like: "faster rendering of pages creates an overall better user experience" just so that it's clear where the developer need springs from - and that what we are doing here is in service of the user experience.

Thanks for this - I added a paragraph saying this.

--------------------

> I'd like to look into this further, but one comment after just a few minutes is that this text:

I appreciate you taking another look!

> 
> > `rendersubtree`, when present, forces `style` and `layout` containment, plus `size` containment if invisible.
> 
> This seems a little bit confusing since those containment values need to persist _after_ `rendersubtree` is removed. So it seems like there needs to be some mechanism for that persistence.

Containment doesn't need to be perisisted after `rendersubtree` is removed. "Removing `rendersubtree`" means not setting the attribute at all, which is different than setting it to the empty string. When the User Agent performs an activation of invisible DOM, it sets `rendersubtree` to the empty string, which still has style and layout containment.

There is also a non-normative note that explains further that it's recommended that the developer set `rendersubtree` to the empty string if it intends to set it to some other value in the future, for the reason of not changing style and layout containment.

If needed, I can clarify the spec text accordingly.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3ctag/design-reviews/issues/306#issuecomment-531455540

Received on Saturday, 14 September 2019 06:52:03 UTC