Re: [whatwg/fetch] Editorial: stop using "promise-calling" (#937)

domenic requested changes on this pull request.

I think this can be much simpler. CreateReadableStream accepts algorithms. You have created an algorithm which promise-calls a function but that function is really just an algorithm.

Instead, you should just pass the algorithms (pull and cancel) to CreateReadableStream semi-directly.

I say "semi-directly" because CreateReadableStream expects the algorithms to return promises. As far as I can tell nothing in the fetch spec needs that. So you need a small wrapper algorithm that returns "a promise resolved with undefined".

But you shouldn't need promise-calling at all, or to go through Web IDL, for this.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/937#pullrequestreview-287871065