Re: [w3c/ServiceWorker] Editorial: Update 'wait for all' usage. (#1463)

mattto approved this pull request.

lgtm

> @@ -1903,8 +1903,8 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe

                     Note: The cache commit is allowed when the response's body is fully received.
 
             1. Add |responsePromise| to |responsePromises|.
-        1. Let |p| be [=waiting for all=] of |responsePromises|.
-        1. Return the result of [=transforming=] |p| with a fulfillment handler that, when called with argument |responses|, performs the following substeps:
+        1. Let |p| be the result of [=getting a promise to wait for all=] of |responsePromises|.
+        1. Return the result of [=upon settling|transforming=] |p| with a fulfillment handler that, when called with argument |responses|, performs the following substeps:

It seems this could align to the spec text of "upon settling", e.g., following the example here: https://heycam.github.io/webidl/#ref-for-dfn-perform-steps-once-promise-is-settled②


Or maybe we could use the "upon fulfillment" hook for these? https://heycam.github.io/webidl/#upon-fulfillment


OK for a later commit.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1463#pullrequestreview-282719705