- From: Marcos Cáceres <notifications@github.com>
- Date: Wed, 23 Oct 2019 18:48:00 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 24 October 2019 01:48:02 UTC
marcoscaceres approved this pull request.
Few little suggestions to apply - otherwise looks great!
> @@ -1951,8 +1950,7 @@ <h3>
The <dfn>orientation</dfn> member is a <a>string</a> that serves as
the <a>default orientation</a> for all <a>top-level browsing
contexts</a> of the web application. The possible values are those of
- the <a>OrientationLockType</a> enum defined in
- [[SCREEN-ORIENTATION]].
+ the {{orientationlocktype}} enum defined in [[SCREEN-ORIENTATION]].
What you have here is correct, but it's wrong in the xref database :) I'll get that fixed as it should be `OrientationLockType`.
> @@ -2836,12 +2831,10 @@ <h3>
{{HTMLLinkElement/sizes}} attribute and let <a>list</a>
<var>keywords</var> be the result.
</li>
- <li>
- <a>For each</a> <var>keyword</var> of <var>keywords</var>:
+ <li>[=list/For each=]> <var>keyword</var> of <var>keywords</var>:
```suggestion
<li>[=list/For each=] <var>keyword</var> of <var>keywords</var>:
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/816#pullrequestreview-306279142
Received on Thursday, 24 October 2019 01:48:02 UTC