- From: Mike West <notifications@github.com>
- Date: Mon, 21 Oct 2019 00:07:59 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/948/review/304360876@github.com>
mikewest commented on this pull request.
> @@ -1567,13 +1573,13 @@ whose <a for=request>destination</a> is "<code>audio</code>", "<code>audioworkle
"<code>object</code>" or "<code>embed</code>".
<p>A <dfn export>non-subresource request</dfn> is a <a for=/>request</a>
-whose <a for=request>destination</a> is "<code>document</code>",
-"<code>report</code>", "<code>serviceworker</code>", "<code>sharedworker</code>",
-or "<code>worker</code>".
+whose <a for=request>destination</a> is "<code>document</code>", "<code>frame</code>",
+"<code>iframe</code>", "<code>report</code>", "<code>serviceworker</code>",
+"<code>sharedworker</code>", or "<code>worker</code>".
So, given that the potential resolution to the underlying question in https://github.com/whatwg/fetch/pull/948#issuecomment-543560997 puts the `embed` and `object` destinations into two categories (depending on the mode), what would you like me to do with these definitions ("navigation request", "non-subresource request"?
Should we leave them as they are in this patch, or do you want to include/excude requests with a `mode` of `navigate` as appropriate?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/948#discussion_r336862935
Received on Monday, 21 October 2019 07:08:01 UTC