- From: Domenic Denicola <notifications@github.com>
- Date: Fri, 18 Oct 2019 10:04:00 -0700
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 18 October 2019 17:04:02 UTC
https://github.com/whatwg/url/pull/453 and https://github.com/web-platform-tests/wpt/pull/19770 do not match.
First, the tests expect gopher to also be removed from the list of origins which get serialized nicely: https://url.spec.whatwg.org/#concept-url-origin
even after that, the following tests fail:
```
Web platform tests › setters › protocol › <gopher://example.net:1234>.protocol = "file"
Expected value to be equal to:
"gopher://example.net:1234/"
Received:
"gopher://example.net:1234"
Web platform tests › setters › protocol › <ssh://me@example.net>.protocol = "gopher"
Expected value to be equal to:
"ssh://me@example.net"
Received:
"gopher://me@example.net"
```
I think these latter two are test issues. The former could either be a test or spec issue, depending on whether people think #454 is correct.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/issues/455
Received on Friday, 18 October 2019 17:04:02 UTC