- From: Marcos Cáceres <notifications@github.com>
- Date: Tue, 15 Oct 2019 17:34:46 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/manifest/pull/815/review/302266906@github.com>
marcoscaceres requested changes on this pull request. Looks great... couple of suggestions and just needs a tidy with HTML5 tidy. > @@ -795,7 +795,7 @@ <h3> <p> The following extensions to the <code><dfn data-cite= "HTML/window-object.html#window">Window</dfn></code> object specify - the <a>event handler attributes</a> on which events relating to the + the <a data-cite="html">event handler idl attribute</a> on which events relating to the ```suggestion the <a>event handler idl attribute</a> on which events relating to the ``` > @@ -907,8 +907,7 @@ <h2> unexpected behavior, use a scope ending in a <code>/</code>. </div> <p> - If the <a>application context</a>'s <a data-cite= - "HTML#active-document">active document</a>'s <a data-cite= + If the <a>application context</a>'s <a data-cite="html">active document</a>'s <a data-cite= ```suggestion If the <a>application context</a>'s <a>active document</a>'s <a data-cite= ``` > @@ -1360,7 +1358,7 @@ <h3> <li>From the {{Document}} of the <a>top-level browsing context</a>, let <var>origin</var> be the {{Document}}'s origin, and <var>manifest link</var> be the first <a><code>link</code> element</a> in <a>tree - order</a> whose <a><code>rel</code> attribute</a> contains the token + order</a> whose {{HTMLLinkElement/rel}} contains the token ```suggestion order</a> whose {{HTMLLinkElement/rel}} attribute contains the token ``` > @@ -1263,8 +1262,7 @@ <h3> </h3> <p> The <code>manifest</code> keyword can be used with a [[HTML]] - <a><code>link</code> element</a>. This keyword creates an <a>external - resource link</a>. + <a><code>link</code> element</a>. This keyword creates an <a data-cite="html">external resource link</a>. ```suggestion [^link^] element. This keyword creates an <a>external resource link</a>. ``` > @@ -1294,7 +1292,7 @@ <h3> <code>manifest</code> </td> <td> - <a>External Resource</a> + <a data-cite="html">External Resource Link</a> ```suggestion <a>External Resource Link</a> ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/815#pullrequestreview-302266906
Received on Wednesday, 16 October 2019 00:34:49 UTC