- From: Jungkee Song <notifications@github.com>
- Date: Tue, 08 Oct 2019 11:56:58 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/653/review/298978865@github.com>
jungkees commented on this pull request. > @@ -1062,15 +1062,19 @@ and an <a>event listener</a> <var>listener</var>, run these steps: <ol> <li> - <p>If <var>eventTarget</var>'s <a>relevant global object</a> is a {{ServiceWorkerGlobalScope}} - object and its associated <a>service worker</a>'s <a for="service worker">script resource</a>'s - <a for="script resource">has ever been evaluated flag</a> is set, then <a>throw</a> a - <code>TypeError</code>. - [[!SERVICE-WORKERS]] - - <p class="note no-backref">To optimize storing the event types allowed for the service worker and - to avoid non-deterministic changes to the event listeners, invocation of the method is allowed - only during the very first evaluation of the service worker script. + <p>If <var>eventTarget</var> is a {{ServiceWorkerGlobalScope}} object and its associated + <a>service worker</a>'s <a for="service worker">script resource</a>'s + <a for="script resource">has ever been evaluated flag</a> is set, then + <a>report a warning to the console</a> with a description explaining that the + <a>service worker event</a> is to be added synchronously, otherwise the user agent may not start Right. I added a condition to do it only for service worker events in the follow-up commit. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/653#discussion_r332678682
Received on Tuesday, 8 October 2019 18:57:06 UTC