- From: Jungkee Song <notifications@github.com>
- Date: Mon, 07 Oct 2019 11:26:31 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/653/review/298323654@github.com>
jungkees commented on this pull request. > - [[!SERVICE-WORKERS]] - - <p class="note no-backref">To optimize storing the event types allowed for the service worker and - to avoid non-deterministic changes to the event listeners, invocation of the method is allowed - only during the very first evaluation of the service worker script. + <p>If <var>eventTarget</var> is a {{ServiceWorkerGlobalScope}} object and its associated + <a>service worker</a>'s <a for="service worker">script resource</a>'s + <a for="script resource">has ever been evaluated flag</a> is set, then + <a>report a warning to the console</a> with a description explaining that the + <a>service worker event</a> is to be added synchronously, otherwise the user agent will not start + the <a>service worker</a> for the <a>event</a>. [[!SERVICE-WORKERS]] + + <p class="note no-backref">To optimize with the set of <a>service worker events</a> to handle, + asynchronously added <a>service worker events</a> are not added to the <a>service worker</a>'s + <a for="service worker">set of event types to handle</a>. The <a>event listener</a> will still be + added under this condition, but the implmentations have to inform developers about this behavior. Fixed. Thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/653#discussion_r332169502
Received on Monday, 7 October 2019 18:26:53 UTC