- From: Jungkee Song <notifications@github.com>
- Date: Mon, 07 Oct 2019 11:21:52 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/653/review/298320911@github.com>
jungkees commented on this pull request. > @@ -1118,11 +1120,12 @@ and an <a>event listener</a> <var>listener</var>, set <var>listener</var>'s method, when invoked, must run these steps: <ol> - <li><p>If the <a>context object</a>'s <a>relevant global object</a> is a - {{ServiceWorkerGlobalScope}} object and its associated <a>service worker</a>'s - <a for="service worker">script resource</a>'s - <a for="script resource">has ever been evaluated flag</a> is set, then <a>throw</a> a - <code>TypeError</code>. [[!SERVICE-WORKERS]] + <li><p>If the <a>context object</a> is a {{ServiceWorkerGlobalScope}} object and its associated + <a>service worker</a>'s <a for="service worker">script resource</a>'s + <a for="script resource">has ever been evaluated flag</a> is set, then + <a>report a warning to the console</a> with a description explaining that the user agent will still + start the <a>service worker</a> for the <a>service worker event</a> that was synchronously added. We are able to know whether the event has been added to the service worker's *set of event types to handle*. But I thought that we'd want to show the warning message when the function is called outside of the first evaluation regardless of whether the event has been added synchronously. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/653#discussion_r332167357
Received on Monday, 7 October 2019 18:22:14 UTC